Extending atmosphere

[shadmar]

I've extended the atmosphere so the the ground doesn't darken long before the sun is below horizon.Light is also scattered in the atmosphere.Maybe the outlined atmosphere is abit fake (should probaly be toned down)?

[Guest]

:O :yahoo:

[Chronothan]

Looks amazing! You even toned down the thick blue fog effect. Hope we can see your work in the next alpha!

[shadmar]

Thanks  Heres a shot from New Hope with new atmopshere :

[Straker]

Atmosphere looks a little thin in the top pic. Isn't there a formula to calculate the thickness of an atmosphere given the mass of a planet?

[Brianetta]

Atmosphere looks a little thin in the top pic. Isn't there a formula to calculate the thickness of an atmosphere given the mass of a planet?No. Simple case in point: Earth and Venus are about the same mass, but have radically different atmospheric thickness.

[s2odan]

I like this! New Hope looks really nice:) Maybe the outlined atmosphere is abit fake (should probaly be toned down)? IMO the transition between space and atmosphere looks too sudden on the top Earth pics, but it looks really good in the pics of New Hope.

[shadmar]

Yeah I've been working on improving it. Thanks s2odan. Here's another shot : 

[shadmar]

Here are some more progress : This is Capitol in scatter atmospheric shader : Approach :[attachment=1626:screenshot-20121227-103811.png] Dayside :[attachment=1625:screenshot-20121227-101422.png] Above city midday :[attachment=1627:screenshot-20121227-104200.png] Evening :[attachment=1628:screenshot-20121227-104349.png]

[shadmar]

Some new Earth shots : In the mountains of Argentina :[attachment=1629:screenshot-20121227-101801.png] Testing light scatter in low orbit :[attachment=1630:screenshot-20121227-101517.png] And New Hope[attachment=1631:screenshot-20121227-102302.png]

[lionheart]

Amazing work. Really hope this gets into the alphas as soon as possible. The stuff you've done on shaders is starting to take pioneer's graphics towards being in the same league as all those fancy tech demos and games like infinity. At the rate you're going fairly soon the shader effects will look just as good as anything out there. Pioneer is actually now starting to look, actually beautiful.

[StarMax]

I agree. The awesome shader work did take Pioneer's graphics to another level.

[Helioth]

Yes, please submit pull requests on github for the wonderful graphical improvements you've shown us here in the Forum.

[walterar]

@shadmar, keep you updated your master (with patches), with the master on github Pioneer?

[shadmar]

Thanks guys. @HeliothI will, but I have no access to merge, so I can't guarantee it will be in the master. I'm still waiting for my volcanos to merged after 3 weeks (with no visible decition).[url]https://github.com/pioneerspacesim/pioneer/pull/1782[/url] which will conflict if I pull this one. @walterar : Yes my master is pretty in sync with the pioneer master, but my branches not so much.

[Brianetta]

Generally speaking, a pull request with conflicts won't be merged until the conflicts are sorted out. I'll keep an eye on PR #1782, and when there are no conflicts I'll go and poke the rest of the dev team.

[fluffyfreak]

Pre-xmas and with trying to get the Alpha ready has probably taken everyones mind off of the PR's, sometimes work posting a message on your own PR with an @RobN or someone else just to get it bumped to their attention Although now you've got Brianetta on the case it should be ok. That and sometimes PR's just take a while to get accepted into a build.

[shadmar]

Generally speaking, a pull request with conflicts won't be merged until the conflicts are sorted out. I'll keep an eye on PR #1782, and when there are no conflicts I'll go and poke the rest of the dev team.Thanks, I will merge it with a30 and check that's not conflicting and notify on the issuetracker. Pre-xmas and with trying to get the Alpha ready has probably taken everyones mind off of the PR's,I fully understand this

[Brianetta]

Thanks, I will merge it with a30 and check that's not conflictingAlpha 30's getting a bit old now. I'd recommend merging master instead.Edit: Um, shows how carefully I keep track. Still, aim for master rather than a tagged release and you can't go wrong...

[shadmar]

Thanks Brianetta, I use the running current master (which is alpha30) no tags.